Skip to content

chore(deps): uninstall unused devDependencies#4302

Open
ulrichstark wants to merge 2 commits into
nitrojs:mainfrom
ulrichstark:chore(deps)--uninstall-unused-devDependencies
Open

chore(deps): uninstall unused devDependencies#4302
ulrichstark wants to merge 2 commits into
nitrojs:mainfrom
ulrichstark:chore(deps)--uninstall-unused-devDependencies

Conversation

@ulrichstark

@ulrichstark ulrichstark commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

I tried and failed to integrate knip into this project.
While doing so I noticed these unused devDependencies and uninstalled them.
I hope I didn't break anything.
Less is always better!

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@ulrichstark ulrichstark requested a review from pi0 as a code owner June 2, 2026 19:51
@vercel

vercel Bot commented Jun 2, 2026

Copy link
Copy Markdown

@ulrichstark is attempting to deploy a commit to the Nitro Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e368b5e9-8882-41b3-9469-0b59e8f97179

📥 Commits

Reviewing files that changed from the base of the PR and between 95f60fb and 0dc36e7.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json
🚧 Files skipped from review as they are similar to previous changes (1)
  • package.json
📝 Walkthrough

Walkthrough

Removes multiple unused devDependencies from package.json: @types/http-proxy, @types/node-fetch, edge-runtime, expect-type, serve-placeholder, and uncrypto. Changes are limited to the devDependencies section.

Changes

Dev dependency cleanup

Layer / File(s) Summary
Remove unused dev dependencies
package.json		 Removes @types/http-proxy, @types/node-fetch, edge-runtime, expect-type, serve-placeholder, and uncrypto from devDependencies.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • nitrojs/nitro#4104: Both PRs remove unused devDependencies from package.json without modifying exported code.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The pull request title follows conventional commits format with type 'chore', scope 'deps', and a clear description of the changes.
Description check ✅ Passed The pull request description clearly relates to the changeset, explaining the context of identifying and uninstalling unused devDependencies.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@pkg-pr-new

pkg-pr-new Bot commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/nitro@4302

commit: 0dc36e7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pi0 pi0 Awaiting requested review from pi0 pi0 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ulrichstark